Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply diagram background styles, fix bounding box bugs #910

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

alixander
Copy link
Collaborator

@alixander alixander commented Feb 26, 2023

Also

  • makes the bounding box of diagrams more accurate on the right/bottom sides.

(case of this having too much padding, which is now reduced)
Screen Shot 2023-02-26 at 3 30 31 PM

(case of this having too little padding, which is now increased)
Screen Shot 2023-02-26 at 4 22 13 PM

  • brings back sketch test SVGs. not comparing their bytes, but good to have for visual comparisons

screencapture-file-Users-alexanderwang-dev-alixander-d2-e2etests-out-e2e-report-html-2023-02-26-12_37_47

These are all with padding=0. Here's with some padding 10):

Screen Shot 2023-02-26 at 12 45 10 PM

i've verified every e2e test delta

closes #663

@alixander alixander force-pushed the root-styles branch 2 times, most recently from 869ebf0 to 89032dc Compare February 27, 2023 00:17
@alixander alixander changed the title apply diagram background styles apply diagram background styles, fix bounding box bugs Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apply root level attributes, e.g. fill for diagram background
1 participant