Clean up 10_wiiu example for PlantUML #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue caused by the alias `rom` being used for two separate elements. Fixed by renaming the second element to `prom`. Another issue was that all arrows were `--` which means up/down to PlantUML. This was fixed by changing some arrows to `-` (meaning left/right). Finally, some arrows were made longer (`---`) to give elements more space to be pointed to. This avoids links crossing.
alixander
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking through the examples, I noticed that the
10_wiiuexample for PlantUML looked "off".On closer inspection, I realized this was because the "16 KB ROM" element was missing. This was caused by the alias
rombeing used for two separate elements. By renaming the second element toprom, this was fixed.As I already had the file open and was
boredvery motivated to contribute I also fixed up the diagram a bit.--which means up/down to PlantUML, by changing some arrows to-(meaning left/right) things look nicer---) to give elements more space to be pointed toThings could be made even nicer with the aid of invisible helper arrows, but this felt like cheating (as that would be work done by the author, not the renderer) and I wanted to watch Netflix. So I didn't.
Anyway, hope this helps. 👍