Fix for custom config file command line argument TypeError bug #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrelsa13
approved these changes
Nov 5, 2023
terrelsa13
added a commit
that referenced
this pull request
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug with the custom config file command line argument (-c). Using the -c command line argument (python mumc.py -c "./config/mumc_config.yaml") would trigger a TypeError exception: unsupported operand type(s) for /: 'str' and 'str'
The custom config file logic was using a combination of string concatenation with "/" between path and filename, as well as the / operator, which is the source of the bug. This is because the / operator is not support on str, but was instead meant to be used on Path objects from pathlib (which works fine with the default non-custom config file logic and init_dict['mumc_path'] because it is a Path object).
The bug fixed by converting the custom config file directory (cmdopt_dict['altConfigPath']) from str to Path and only using the / operator in the custom config file logic.