Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tracking line color on Maps #3670

Merged

Conversation

jheredianet
Copy link
Contributor

This is a proposal to change the color of the tracking lines in all the Grafana dashboards with Maps, from red to blue, since the color red often overlaps with the color of the map's own highways and becomes difficult to distinguish.
At the same time, I took the opportunity to update the plugins on the corresponding Grafana dashboards.

Here's a sample.

Before:
image

After:
image

Most of navigators like Google Maps or the same navigation system of Tesla, the tracking line is "Blue".

Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit f6471e1
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/65d86ef2ea235c00085693ce
😎 Deploy Preview https://deploy-preview-3670--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakobLichterfeld
Copy link
Collaborator

Thanks for the suggestion. Please change the UID, as we get a strange spelling error with it: https://github.com/teslamate-org/teslamate/actions/runs/7874774381/job/21485158253?pr=3670#step:11:45

@JakobLichterfeld JakobLichterfeld added enhancement New feature or request area:grafana Related to Grafana labels Feb 13, 2024
@jheredianet
Copy link
Contributor Author

Thanks for the suggestion. Please change the UID, as we get a strange spelling error with it: https://github.com/teslamate-org/teslamate/actions/runs/7874774381/job/21485158253?pr=3670#step:11:45

Yeah, it's strange. Now it's fixed. Thanks

@JakobLichterfeld
Copy link
Collaborator

As I remember correctly, we had the discussion before to change the color of the lines in maps. In the end, blue lines will be a problem in more regions, correct @swiffer and @oivindoh?

@oivindoh
Copy link
Contributor

There was some talk at least in #3439 (comment) - i originally switched to blue in that PR, but reverted it.

Personally I buy the comment about blue having become the standard for routes, but the default OSM map makes blues without a border look a bit washed out, maybe.

@JakobLichterfeld JakobLichterfeld merged commit a59ac06 into teslamate-org:master Feb 26, 2024
12 checks passed
@jheredianet jheredianet deleted the map-tracking-line-color branch February 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:grafana Related to Grafana enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants