Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing translation for Korean #3693

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

zipizigi
Copy link
Contributor

add new message translation for korean

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 32fd00a
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/65dee8fe64367500081175f9
😎 Deploy Preview https://deploy-preview-3693--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakobLichterfeld JakobLichterfeld added the enhancement New feature or request label Feb 28, 2024
Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your change.

@JakobLichterfeld JakobLichterfeld self-requested a review February 28, 2024 08:02
Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your change. One small finding, see inline comment


#: lib/teslamate_web/live/car_live/summary.ex:139
#, elixir-autogen, elixir-format
msgid "Dog mode is enabled"
msgstr ""
msgstr "애견 모드가 켜져있습니다.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be in " atz the end as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I made a mistake.
problem has been fixed.

Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JakobLichterfeld JakobLichterfeld merged commit 28cfdba into teslamate-org:master Feb 28, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants