-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors from Timex.Timezone.local() during switchover to DST. #3848
Fix errors from Timex.Timezone.local() during switchover to DST. #3848
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Good catch. |
Fixed now (sorry, I thought that error was just something random). |
Arggh. Not the first time I have had problems with Timex failing to deal with daylight savings correctly. bitwalker/timex#660 |
@brianmay I'm hopeful that Timex.local will also work for your time zone. |
Thanks. The PR is now a bit messy. As your branch was not up to date with latest master |
I've merged the changes from the latest master if that makes any difference. |
Thanks, was my bad, as the pot files really needed to be updated as the line number changes due to your change :-) |
During the hour of the switchover to DST at the end of March, errors like below were logged while the car was charging:
I've reported this as a bug in Timex at bitwalker/timex#755 but the problem can be avoided in TeslaMate with the attached pull request.