Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display vehicle VIN as a fallback for vehicle name on grafana dashboards #4198

Merged
merged 1 commit into from
Sep 15, 2024
Merged

feat: display vehicle VIN as a fallback for vehicle name on grafana dashboards #4198

merged 1 commit into from
Sep 15, 2024

Conversation

arcastro
Copy link
Contributor

@arcastro arcastro commented Sep 14, 2024 •
edited
Loading

Context

  • In cases of unnamed vehicles,
    • The grafana dashboards currently display "null".
    • This pull-requests adds fallback logic to display the vehicle vin instead.
  • for cases of named vehicles
    • the behavior remains unchanged and the vehicle name is still displayed.

Before

After

Links

@netlify Netlify
Copy link

netlify bot commented Sep 14, 2024 •
edited
Loading

✅ Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 4903ca1
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/66e5d149dbcd710008406286
😎 Deploy Preview https://deploy-preview-4198--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakobLichterfeld JakobLichterfeld added the area:dashboard Related to a Grafana dashboard label Sep 15, 2024
JakobLichterfeld
JakobLichterfeld approved these changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and thanks for your changes!

@JakobLichterfeld JakobLichterfeld changed the title fix: display vehicle vin as a fallback for vehicle name on grafana dashboards. feat: display vehicle VIN as a fallback for vehicle name on grafana dashboards Sep 15, 2024
@JakobLichterfeld JakobLichterfeld merged commit 8cae4d8 into teslamate-org:master Sep 15, 2024
12 checks passed
@arcastro arcastro mentioned this pull request Nov 4, 2024
Merged
@swiffer swiffer mentioned this pull request Nov 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobLichterfeld JakobLichterfeld JakobLichterfeld approved these changes

Assignees
No one assigned
Labels
area:dashboard Related to a Grafana dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arcastro @JakobLichterfeld