Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated functionality to use venv instead of virtualenv #51

Merged
merged 6 commits into from
Jul 12, 2024

Conversation

sedillo
Copy link
Contributor

@sedillo sedillo commented Jul 8, 2024

Potential fix for the virtualenv describe here: #50

The PR uses venv instead of virtualenv to create the virtual environment.

@sedillo
Copy link
Contributor Author

sedillo commented Jul 9, 2024

It was pointed out that this might break backward compatibility so i'm adding python version checking.

Copy link
Collaborator

@dfinninger dfinninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@dfinninger dfinninger merged commit e669188 into teslamotors:master Jul 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants