Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RandomAccessIterator] Fix reference to non-existent member #129

Merged

Conversation

alexkaratarakis
Copy link
Collaborator

@alexkaratarakis alexkaratarakis commented Jun 20, 2024

Exposed by #128

This was previously building without issue due to two-phase lookup and the function never being called. New units tests will instantiate this function.

template <class T>
struct MockTemplate
{
    int foo(const MockTemplate<T>& input) const { return input.variable_that_does_not_exist; }
};

int main()
{
    MockTemplate<int> it{};
    (void)it;
    // it.foo(it);
}

Exposed by teslamotors#128

This was previously building without issue due to two-phase lookup and
the function never being called. New units tests will instantiate
this function.

```C++
template <class T>
struct MockTemplate
{
    int foo(const MockTemplate<T>& input) const { return input.variable_that_does_not_exist; }
};

int main()
{
    MockTemplate<int> it{};
    (void)it;
    // it.foo(it);
}

```
@alexkaratarakis alexkaratarakis changed the title [RandomAccessIterator] Fix access to non-existent member [RandomAccessIterator] Fix reference to non-existent member Jun 20, 2024
@alexkaratarakis alexkaratarakis merged commit 32b3590 into teslamotors:main Jun 20, 2024
5 checks passed
@alexkaratarakis alexkaratarakis deleted the non-existent-member branch June 20, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant