-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check_server_cert.sh #110
Conversation
die "could not find json config file: $CONFIG" | ||
fi | ||
|
||
HOSTNAME=$(jq -r ".hostname" "$CONFIG") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be .host
?
fleet-telemetry/config/config.go
Line 31 in 613041e
Host string `json:"host,omitempty"` |
HOSTNAME=$(jq -r ".hostname" "$CONFIG") | |
HOSTNAME=$(jq -r ".host" "$CONFIG") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SirArkimedes thanks for the feedback, but this script is for validating server setup is compatible with a proposed vehicle config (which uses "hostname"). I've updated the README, and error messaging.
fi | ||
|
||
HOSTNAME=$(jq -r ".hostname" "$CONFIG") | ||
CA=$(jq -r ".ca" "$CONFIG") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be .ca_file
?
fleet-telemetry/config/config.go
Line 131 in 613041e
CAFile string `json:"ca_file"` |
CA=$(jq -r ".ca" "$CONFIG") | |
CA=$(jq -r ".ca_file" "$CONFIG") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's the server config. This script accepts a fleet telemetry client config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhhh. Okay, the new README updates make this make sense, then! Thanks!
7aa2656
to
f08040a
Compare
Description
Adds a script
tools/check_server_cert.sh
to validate client configs against telemetry servers.Type of change
Please select all options that apply to this change:
Checklist: