Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix airbrake notice message #149

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Fix airbrake notice message #149

merged 1 commit into from
Apr 8, 2024

Conversation

agbpatro
Copy link
Collaborator

@agbpatro agbpatro commented Apr 8, 2024

Description

Errbit logs error like this
Screenshot 2024-04-08 at 13 31 49
This format isn't useful. Making following changes

  • logType is int. logrus.AllLogType[logType] will return value in string
  • err.Error() extracts error message to be logged properly in airbrake

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.
  • I have added/updated integration tests to cover my changes.

@agbpatro agbpatro merged commit 3e395bc into main Apr 8, 2024
5 checks passed
@agbpatro agbpatro deleted the fix_error_messages branch April 8, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants