Do not set opaque object if reliable ack workers are not set. This fixes a potential memory leak issue #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronpkahn
approved these changes
Apr 9, 2024
…xes a potential memory leak issue Kafka allows you to send opaque entry which are used for post processing flows. we should only set that field if reliable ack workers are configured
agbpatro
force-pushed
the
handle_reliable_ack_workers_gracefully
branch
from
1c1e012
to
23bb5f1
Compare
agbpatro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kafka allows you to send opaque entry which are used for post processing flows. we should only set that field if reliable ack workers are configured
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: