Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics for dispatched record size #154

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix metrics for dispatched record size #154

merged 1 commit into from
Apr 10, 2024

Conversation

agbpatro
Copy link
Collaborator

Description

In datastore, we use Length() to instrument payload size sent to them. However the value which was instrumented was the flatbuffer message. Fixing here to use the actual payload length

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.
  • I have added/updated integration tests to cover my changes.

In datastore, we use Length() to instrument payload size sent to them. However the value which was instrumented was the flatbuffer message. Fixing here to use the actual payload length
@agbpatro agbpatro mentioned this pull request Apr 10, 2024
9 tasks
@agbpatro agbpatro merged commit e902968 into main Apr 10, 2024
5 checks passed
@agbpatro agbpatro deleted the fix_metrics_length branch April 10, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants