Add kafka metrics related to local queue size #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agbpatro
commented
Apr 11, 2024
| interval := time.Minute | ||
| t := time.NewTicker(interval) | ||
| for range t.C { | ||
| total := p.kafkaProducer.Len() |
There was a problem hiding this comment.
this is total length including the delivered events
agbpatro
force-pushed
the
producer_len_metrics_kafka
branch
from
ad9d5fc
to
08fd7d2
Compare
vmallet
reviewed
Apr 11, 2024
datastore/kafka/kafka.go
Outdated
| produceAckCount adapter.Counter | ||
| bytesAckTotal adapter.Counter | ||
| errorCount adapter.Counter | ||
| produceQueueSize adapter.Gauge |
datastore/kafka/kafka.go
Outdated
| @@ -130,6 +132,18 @@ func (p *Producer) logError(err error) { | |||
| metricsRegistry.errorCount.Inc(map[string]string{}) | |||
| } | |||
|
|
|||
| func (p *Producer) reportProducerMetrics() { | |||
| interval := time.Minute | |||
There was a problem hiding this comment.
One minutes feels like a really long interval; 5s? It should be super cheap right?
Adds a go routine which periodically tracks pending messages to be sent to the broker.
agbpatro
force-pushed
the
producer_len_metrics_kafka
branch
from
08fd7d2
to
90937f8
Compare
vmallet
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a go routine which periodically tracks pending messages to be sent to the broker.
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: