Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more experimental fields #159

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Add more experimental fields #159

merged 1 commit into from
Apr 12, 2024

Conversation

agbpatro
Copy link
Collaborator

@agbpatro agbpatro commented Apr 11, 2024

Description

Add another experimental field

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.
  • I have added/updated integration tests to cover my changes.

@@ -175,6 +175,7 @@ enum Field {
DiInverterTF = 165;
DiInverterTREL = 166;
DiInverterTRER = 167;
Experimental_5 = 168;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add 5->15 for a bit of buffer here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@agbpatro agbpatro changed the title Add another experimental field Add more experimental fields Apr 11, 2024
@agbpatro agbpatro merged commit f36e2e5 into main Apr 12, 2024
5 checks passed
@agbpatro agbpatro deleted the add_experimental_field branch April 12, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants