Add status server on http port #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronpkahn
approved these changes
Jun 2, 2023
| @@ -92,11 +92,16 @@ var _ = Describe("Test vital payload messages", Ordered, func() { | |||
| VerifyMessageBody(msg.Value, vehicleName, timestamp) | |||
| }) | |||
|
|
|||
| It("returns 200 for status", func() { | |||
| It("returns 200 for mtls status", func() { | |||
| err := VerifyHTTPSRequest(serviceURL, "status", tlsConfig) | |||
| Expect(err).To(BeNil()) | |||
There was a problem hiding this comment.
nit: could we validate the response body here?
agbpatro
force-pushed
the
use_non_tls_status_port
branch
5 times, most recently
from
6c61786
to
79ef6cb
Compare
agbpatro
force-pushed
the
use_non_tls_status_port
branch
from
79ef6cb
to
7c0b8e9
Compare
aaronpkahn
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update unit and integration tests as well
#17