Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated validator for XLights 2023.04 (FSEQ Version 2.2) #68

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

spaceXrace
Copy link
Contributor

FSEQ Version changed to accept FSEQ version 2.0 and 2.2, the validator only accepted 2.0 before.

I can play V2.2 on the car without problems, however other users have reported problems: https://www.reddit.com/r/TeslaLightShow/comments/121gx31/comment/jdu6wyq/?context=3

Issue is described here: #67

This update also includes a minor fix in the manual.

In XLights 2023.4, the Minor Version of the .fseq files changed to 2.
In the Layout Tab, there is no single Model S object anymore.
Copy link
Collaborator

@JVB-Tesla JVB-Tesla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this to print a warning message if FSEQ version is not 2.0 or 2.2, but not have it fail the validator.

Warning text suggested -

Warning: FSEQ version X.Y detected. Only versions 2.0 and 2.2 have been validated.

If FSEQ Version changes again, this warning will appear:

WARNING: FSEQ version is X.Y. Only version 2.0 and 2.2 have been validated.
If the car fails to read this file, download and older version of XLights at https://github.com/smeighan/xLights/releases
Please report this warning at https://github.com/teslamotors/light-show/issues

Found 9287 frames, step time of 20 ms for a total duration of 0:03:05.740000.
Used 41.29% of the available memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants