Skip to content

Commit

Permalink
FA-11461: Fix maven central URLs by moving to https
Browse files Browse the repository at this point in the history
On Jan 15 2020, maven central repo removed all access to http endpoints.
This is covered here: https://blog.sonatype.com/central-repository-moving-to-https

This change fixes all the broken URLs. Upstream has a similar change here
bazelbuild#920

We cant use upstream cherry pick because the version we use internally at Tesla
is quite old and the cherry pick doesn't apply cleanly.
  • Loading branch information
shrijeet-tesla committed Mar 18, 2020
1 parent a76b311 commit fe5d292
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ java_import_external(
name = "org_apache_commons_commons_lang_3_5_without_file",
generated_linkable_rule_name = "linkable_org_apache_commons_commons_lang_3_5_without_file",
jar_sha256 = "8ac96fc686512d777fca85e144f196cd7cfe0c0aec23127229497d1a38ff651c",
jar_urls = ["http://central.maven.org/maven2/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar"],
jar_urls = ["https://repo.maven.apache.org/maven2/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar"],
licenses = ["notice"], # Apache 2.0
neverlink = True,
)
Expand Down
2 changes: 1 addition & 1 deletion scala/scala.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ def scala_repositories(
_default_scala_version(),
_default_scala_version_jar_shas(),
),
maven_servers = ["http://central.maven.org/maven2"],
maven_servers = ["https://repo.maven.apache.org/maven2"],
scala_extra_jars = _default_scala_extra_jars()):
(scala_version, scala_version_jar_shas) = scala_version_shas
major_version = _extract_major_version(scala_version)
Expand Down
4 changes: 2 additions & 2 deletions scala_proto/scala_proto.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ load(

def scala_proto_repositories(
scala_version = _default_scala_version(),
maven_servers = ["http://central.maven.org/maven2"]):
maven_servers = ["https://repo.maven.apache.org/maven2"]):
major_version = _extract_major_version(scala_version)

native.maven_server(
name = "scala_proto_deps_maven_server",
url = "http://central.maven.org/maven2/",
url = "https://repo.maven.apache.org/maven2/",
)

native.maven_jar(
Expand Down
2 changes: 1 addition & 1 deletion specs2/specs2.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def specs2_version():

def specs2_repositories(
scala_version = _default_scala_version(),
maven_servers = ["http://central.maven.org/maven2"]):
maven_servers = ["https://repo.maven.apache.org/maven2"]):
major_version = _extract_major_version(scala_version)

scala_jar_shas = {
Expand Down
2 changes: 1 addition & 1 deletion specs2/specs2_junit.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ load(

def specs2_junit_repositories(
scala_version = _default_scala_version(),
maven_servers = ["http://central.maven.org/maven2"]):
maven_servers = ["https://repo.maven.apache.org/maven2"]):
major_version = _extract_major_version(scala_version)

specs2_repositories(scala_version, maven_servers)
Expand Down
2 changes: 1 addition & 1 deletion twitter_scrooge/twitter_scrooge.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ _jar_extension = ".jar"

def twitter_scrooge(
scala_version = _default_scala_version(),
maven_servers = ["http://central.maven.org/maven2"]):
maven_servers = ["https://repo.maven.apache.org/maven2"]):
major_version = _extract_major_version(scala_version)

native.maven_server(
Expand Down

0 comments on commit fe5d292

Please sign in to comment.