add diagram documenting request flow through system #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickdemers6
force-pushed
the
system-flow-diagram
branch
from
8962978
to
842fa36
Compare
|
|
||
| "Your Backend" -> "Vehicle Commands Proxy": GET /api/1/vehicles/$VIN/command/flash_lights | ||
| activate "Vehicle Commands Proxy" | ||
| "Vehicle Commands Proxy" -> "Vehicle Commands Proxy": Sign command using private key |
There was a problem hiding this comment.
Would the diagram become too crowded if we included also showed the OAuth token being sent from the backend to the proxy and from the proxy to Fleet API?
patrickdemers6
force-pushed
the
system-flow-diagram
branch
from
842fa36
to
693d928
Compare
patrickdemers6
force-pushed
the
system-flow-diagram
branch
from
693d928
to
f14f79a
Compare
sethterashima
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a document to explain how the proxy works and how public/private keys are used.
Similar change: teslamotors/fleet-telemetry#166
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: