Fast fail 429 #243
Merged
Fast fail 429 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2024 10:38
Fast fail on 429, allowing clients to determine how to handle these errors.
The `TESLA_CACHE_FILE` allows applications to skip handshake messages, which is especially useful for `tesla-control`. It should be documented in the main README file.
thefireblade
approved these changes
May 20, 2024
agbpatro
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fast fail on 429 errors to give clients better control over retry policies.
Document TESLA_CACHE_FILE environment variable, which may help clients avoid 429s to begin with.
Fixes #238
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: