Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip infotainment handshake on BLE wake #254

Conversation

sethterashima
Copy link
Collaborator

Description

If we're sending a wake command over BLE, then infotainment is probably sleeping and we should skip trying to handshake with it.

Fixes #248

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.

If we're sending a wake command over BLE, then infotainment is probably
sleeping and we should skip trying to handshake with it.
@sethterashima sethterashima force-pushed the skip-infotainment-handshake-on-ble-wake branch from c717c12 to 83e7c12 Compare June 3, 2024 21:16
@sethterashima sethterashima merged commit 664a028 into teslamotors:main Jun 13, 2024
1 check passed
@Maddimax
Copy link

This change breaks the wake command. It does not seem to wake up the car via BLE anymore. Reverting this change lets the wake command work again on my Tesla Model 3 SR - 2021

@erikgieseler
Copy link

I cannot confirm this.
After the changes, the wake command still works for me without any problems.
Model 3 LR 2021.

@Maddimax
Copy link

You are correct, sry about that. I was confused by the not working fleet-api (rate-limiting) which meant that the state change was not shown. Wake with this change works for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

impossible to wake up the car with BLE
5 participants