Fetch limited vehicle info over BLE #263
Merged
+1,098
−364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 20, 2024 13:20
The `cli` package was using strings instead of enum types in its API, which is error prone.
New command fetchs limited information about body controller states. The advantage of this command over the more comprehensive vehicle data endpoint is that it works over BLE.
agbpatro
reviewed
Jul 1, 2024
|
|
||
| message ClosureStatuses | ||
| { | ||
| ClosureState_E frontDriverDoor = 1; |
There was a problem hiding this comment.
nit: can we make 0 as UNKNOWN?
There was a problem hiding this comment.
This isn't an enum type; those are field numbers, not enum values. :)
agbpatro
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New command fetches limited information about body controller states. The
advantage of this command over the more comprehensive vehicle data
endpoint is that it works over BLE.
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: