Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non root image #325

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Use non root image #325

merged 1 commit into from
Oct 21, 2024

Conversation

agbpatro
Copy link
Collaborator

Description

Similar to teslamotors/fleet-telemetry#224, there should be no need to run the docker image as root

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.

@sethterashima
Copy link
Collaborator

You marked this as a breaking change; what does it break?

@agbpatro
Copy link
Collaborator Author

You marked this as a breaking change; what does it break?

Changing of privileges for docker image is kind of breaking change? But maybe not?

@agbpatro agbpatro merged commit 5a61b6a into main Oct 21, 2024
1 check passed
@agbpatro agbpatro deleted the agbpatro-patch-1 branch October 21, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants