Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Ability to override drilldown link by adding drillDownKey in row meta #535

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

Lourence94
Copy link
Contributor

Url can be taken from field data by given drillDownKey, otherwise stays default drilldown behaviour

@Lourence94 Lourence94 requested a review from Dergash December 16, 2020 14:06
@Lourence94
Copy link
Contributor Author

/alpha

1 similar comment
@Lourence94
Copy link
Contributor Author

/alpha

@coveralls
Copy link
Collaborator

coveralls commented Dec 17, 2020

Pull Request Test Coverage Report for Build 442184841

  • 21 of 28 (75.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 52.171%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hooks/useDrillDownUrl.ts 13 15 86.67%
src/epics/router.ts 0 5 0.0%
Totals Coverage Status
Change from base Build 441424864: -0.1%
Covered Lines: 2828
Relevant Lines: 4619

💛 - Coveralls

@Lourence94
Copy link
Contributor Author

/alpha

src/hooks/useDrillDownUrl.ts Outdated Show resolved Hide resolved
src/hooks/useDrillDownUrl.ts Outdated Show resolved Hide resolved
@Lourence94 Lourence94 force-pushed the feat/drilldown-override branch 2 times, most recently from 29f38f3 to 8427397 Compare December 24, 2020 10:29
@Lourence94 Lourence94 force-pushed the feat/drilldown-override branch from 8427397 to 3bd0e69 Compare December 24, 2020 10:50
@Dergash Dergash merged commit eca8f9c into develop Dec 24, 2020
@Dergash Dergash added this to the 1.26.0 milestone Dec 24, 2020
@Dergash Dergash added the enhancement New feature or request label Dec 24, 2020
@Dergash Dergash deleted the feat/drilldown-override branch April 28, 2021 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants