Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Remove backend-affecting types and reexport them from "@tesler-ui/schema" #582

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

Dergash
Copy link
Member

@Dergash Dergash commented Jan 28, 2021

There are a lot of types that declared in Tesler UI while in fact those types describe both frontend entities and parts of screen/view/widget/sqlbc JSON descriptions which are stored in backend side of the application, which leads us to:

  1. To generate JSON schemas we'll have to keep a separate instance of all the types in @tesler-ui/schema, which is a double work and will definetly end up out of sync with each outher
  2. This types being declared in Tesler UI are encouraging developers to modify the public contract which is in fact also affects how Tesler API processes JSON descriptors for application entities.

Extracting them into separate repository will allow us to have a single source of truth about types affecting both frontend and JSON descriptors for application entities.

This PR adds @tesler-ui/schema and reexport those types from there so that client application could continue to referencing those types from Tesler UI.

@Dergash Dergash added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jan 28, 2021
@Dergash Dergash requested review from DRITE and Lourence94 January 28, 2021 08:49
@coveralls
Copy link
Collaborator

coveralls commented Jan 28, 2021

Pull Request Test Coverage Report for Build 517493683

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 58.494%

Totals Coverage Status
Change from base Build 515641728: -0.1%
Covered Lines: 3195
Relevant Lines: 4721

💛 - Coveralls

@Dergash Dergash merged commit e3598ac into develop Jan 31, 2021
@Dergash Dergash deleted the feat/schema branch January 31, 2021 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants