This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Allow custom invokes to read raw input data when invoked without specific record #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
AbstractResponseService#invokeAction
implicitly suggests that custom actions could only be invoked for existing records:tesler/tesler-core/src/main/java/io/tesler/core/crudma/impl/AbstractResponseService.java
Lines 229 to 254 in 6512494
So if custom action called without providing a cursor the data from the request will not be passed into the service.
This doesn't seem right as there are at least valid two scenarios I can think of for invoking custom action without pre-existing record:
action roles
concept). We don't have record id yet but we can receive input data and implement creation logic in serviceSo basically the suggestion is to allow the service to handle custom actions input in any way needed.