Add support for marketplace plan information #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonwbarnett
force-pushed
the
feature/add-plan-support
branch
3 times, most recently
from
4d27740 to
8765ebc
Compare
jasonwbarnett
commented
Apr 20, 2020
| @@ -20,6 +20,8 @@ class Azurerm < Kitchen::Driver::Base | |||
| attr_accessor :resource_management_client | |||
| attr_accessor :network_management_client | |||
|
|
|||
| kitchen_driver_api_version 2 | |||
There was a problem hiding this comment.
I mainly added this cause I saw across the board the primary drivers have this set. Willing to pull if this is a big deal.
jasonwbarnett
force-pushed
the
feature/add-plan-support
branch
from
8765ebc to
06084a0
Compare
Signed-off-by: Jason Barnett <jason.w.barnett@gmail.com>
jasonwbarnett
force-pushed
the
feature/add-plan-support
branch
5 times, most recently
from
b577a59 to
959f393
Compare
Signed-off-by: Jason Barnett <jason.w.barnett@gmail.com>
jasonwbarnett
force-pushed
the
feature/add-plan-support
branch
from
959f393 to
adfb2f4
Compare
|
Ready for review |
|
Looks good. Thanks @jasonwbarnett |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for marketplace images that have associated plans.
I manually ran integration tests and this works as expected. With and without the plan information.
Issues Resolved
N/A
Check List