refactor!: Run chefstlye over the codebase #408
Conversation
- Run chefstyle - Move development dependencies into the Gemfile - Remove tailor and cane which are no longer maintained Signed-off-by: Dan Webb <dan.webb@damacus.io>
|
@test-kitchen/maintainers here's the promised move to ChefStyle. I'm not sure why this wasn't using ChefStyle before. Anyone but @xorima can review this one 😆 😆 |
|
@damacus i didn't read the above and approved it 😂 |
damacus
dismissed
xorima’s stale review
I'd like a review from someone not on holiday 😂
|
Fancy fixing the tests to run on defined platforms @damacus |
|
@xorima what do you mean? The kitchen tests currently run on the same platform set as the kitchen.yml default and capabilities are failing due to including busser-serverspec. This needs to be fixed in a subsequent PR. Given the size of the rubocopping on this branch I'm inclined to make non-related changes in another PR |
|
@damacus makes total sense. Tbh I did a spot check of the windows failure and it was failing around platform not defined etc. moving this to a different pr to fix is the better approach I agree. (I've looked at a couple others now and they actually run something so it was just my luck during spot check) |
Description
Please describe what this change achieves
Issues Resolved
List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant
Type of Change
Check List