Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for proxy? #126

Closed
litjoco opened this issue May 21, 2015 · 5 comments · Fixed by #131
Closed

Support for proxy? #126

litjoco opened this issue May 21, 2015 · 5 comments · Fixed by #131
Assignees

Comments

@litjoco
Copy link

litjoco commented May 21, 2015

I am seeing failures when behind a proxy which was working on a previous version. I have the proxy environment variables set.

I think the ability to connect from behind a proxy has been lost when moving from fog to the AWS sdk.

I'm not familiar with the aws sdk, but think the ec2 client can be supplied a http_proxy in the config option.

@tyler-ball
Copy link
Contributor

@litjoco Are you setting the environment variables as defined http://docs.aws.amazon.com/cli/latest/userguide/cli-http-proxy.html ?

@litjoco
Copy link
Author

litjoco commented May 25, 2015

@tyler-ball Yes- the environment variables are set. Having these set worked previously-with a commit ref pre-aws sdk I believe. I have the aws cli installed and it works as expected with the env vars set.

Is there another mechanism that TK is expecting proxy supplied that I'm not aware of?

Thanks for your work on helping resolve

@tyler-ball
Copy link
Contributor

@litjoco I added a comment in the PR, but I'll ask here too: I'm currently defaulting the http_proxy to ENV['HTTP_PROXY'] but because the AWS SDK V2 only accepts 1 proxy would you rather it defaulted to ENV['HTTPS_PROXY'] || ENV['HTTP_PROXY']?

@bookshelfdave
Copy link

looks good, +1 for ENV['HTTPS_PROXY'] || ENV['HTTP_PROXY']

@litjoco
Copy link
Author

litjoco commented May 27, 2015

@tyler-ball I added a comment to the pull request in agreement with @metadave

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants