Fixing 2 regressions in 0.9.1 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etwork_interfaces when network_interfaces is present, fixes #127
| @user_data = File.read(config[:user_data]) | ||
| else | ||
| @user_data = config[:user_data] | ||
| end | ||
| @user_data = Base64.encode64(@user_data) |
There was a problem hiding this comment.
Interesting, that seems to be a low-level concern that we need to deal with as a user of the sdk. Ah well
|
Yep, LGTM! 👍 |
|
any idea when this will get merged? |
tyler-ball
added a commit
that referenced
this pull request
May 26, 2015
Fixing 2 regressions in 0.9.1
|
@tyler-ball Thanks! |
|
Thank you 👍 |
|
I'm having trouble now with the ec2-instance being created and immediately On Tue, May 26, 2015 at 10:15 AM, litjoco notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
Fixes #127
Also setting the network interface to
delete_on_terminationof the instance so there aren't orphan devices hanging around\cc @fnichol @kplimack @litjoco