Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support duration for spot instances #214

Merged
merged 1 commit into from
Feb 16, 2016

Conversation

wjordan
Copy link
Contributor

@wjordan wjordan commented Jan 21, 2016

Fixed-duration spot instances were launched recently and added to the AWS SDK. This PR adds support for the block_duration_minutes parameter in the request_spot_instances AWS sdk method, through a :block_duration_minutes config option.

@jkeiser
Copy link
Contributor

jkeiser commented Feb 12, 2016

To match AWS, could you please name the configuration parameter block_duration_minutes? Thanks! Other than that, I'm 👍.

@proffalken
Copy link

Happy to approve once rebase has taken place

@wjordan
Copy link
Contributor Author

wjordan commented Feb 16, 2016

all set, thanks for taking a look!

@proffalken
Copy link

LGTM +1 :)

jkeiser added a commit that referenced this pull request Feb 16, 2016
support duration for spot instances
@jkeiser jkeiser merged commit 57971e0 into test-kitchen:master Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants