Use github_changelog_generator for changelog #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeiser
force-pushed
the
jk/changelog
branch
from
14e9d00 to
9441e93
Compare
|
|
||
| ### Bug Fixes | ||
| ## [1.0.0.beta.2](https://github.com/test-kitchen/kitchen-ec2/tree/1.0.0.beta.2) (2016-02-26) |
There was a problem hiding this comment.
Are you going to do the final 1.0.0 changelog after this is merged, or should that be in this PR?
|
👍 |
|
It seems as though this change is more than just a changelog / process change as there's some reserved-instance-related stuff in here? I'm 👍 regardless, but perhaps we should update the title and/or add some text to the description of the PR for good record-keeping. |
|
@adamleff it actually was just this, I had rebased from a non-master branch that I had made to fix rubocop so that change happened to get in here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.