Clean up original Authentication; Rely on SDK for Chain. #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will resolve #344. |
|
Cleaned up the test suite to remove the creds testing, since it doesn't exist anymore. |
|
This looks great! We'll give this a look but the simplification is long overdue. |
|
This was tagged for 1.4.0, but didn't make it into the release. Is there a reason? And is there a plan to get it merged anytime soon? Trying to use this across a team, and maintaining a one-off is tedious. (: |
|
It was tagged as 1.4. for a hot minute before we decided it needed to be a major release thing and there were lots of other fixes that could go out with less impact. I'm gearing up for the 2.x release (granted this is the most major change) shortly but 1.4 has only been out a day or so. |
This was referenced Dec 1, 2017
dalvizu
added a commit
to dalvizu/kitchen-ec2
that referenced
this pull request
Jan 2, 2018
test-kitchen#353 was linking to test-kitchen#320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the logic for searching for authentication credentials in favor of just relying on the SDK to find credentials through the standard means. This is necessary to allow role delegation using source_profile configurations for credentials. None of the authentication classes the SDK provides will support that, but if you let the SDK just do all the work to find the credentials, everything just works. This also greatly simplifies the logic within the kitchen-ec2 client wrapper.
I suspect this will break most/all of the tests in client_spec.rb because everything it tests is gone. I vote for just removing it, and passing the buck to the SDK for both finding, and testing all the various methods, of credential finding. I didn't remove the tests in this PR yet, pending discussion on that point.