Ensure tags keys are strings as expected by AWS SDK #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit transform all tags key to Strings, because the ec2 SDK requires it. See https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-ec2/lib/aws-sdk-ec2/tag.rb#L260 This is a reproduction of test-kitchen#111 which I think reoccured when we switch from aws-sdk to aws-sdk-ec2 in 434dc6c97d4a3c4d97ff1f1515a323dc8bc4636. Signed-off-by: Baptiste Courtois <b.courtois@criteo.com>
cheeseplus
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit transform all tags key to Strings, because the ec2 SDK requires it.
See https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-ec2/lib/aws-sdk-ec2/tag.rb#L260
This is a reproduction of #111 which I think reoccured when we switch from aws-sdk to aws-sdk-ec2 in 434dc6c97d4a3c4d97ff1f1515a323dc8bc4636.
Tests have been updated and a new "dummy" one has been added for non-regression.