Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore case when checking if the instance provisioner is Chef #474

Merged
merged 2 commits into from
Dec 29, 2019

Conversation

r1x1
Copy link

@r1x1 r1x1 commented Nov 22, 2019

Changes:

  • Ignores the case of "chef" when determining if the instance provisioner is Chef.
  • Added some whitespace to make rubocop happy so the build passes.

I noticed this issue when the 'ec2' node attributes weren't being populated by ohai, despite using the EC2 driver.

The .name method (defined in configurable here), is based on the class name of the provisioner, which is generally going to be capitalized.

@tas50 tas50 merged commit f18d64e into test-kitchen:master Dec 29, 2019
@r1x1 r1x1 deleted the chef_case_insensitive_ohai branch May 15, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants