Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config for private ssh key for Vagrant #23

Closed
wants to merge 1 commit into from

Conversation

manul
Copy link
Contributor

@manul manul commented May 12, 2013

Will make it possible to configure your own private ssh key for vagrant instead of
the default vagrant private key.

Will set the ssh_key in the Vagrantfile if the ssh_key attribute is set in .kitchen.yml
This didn't work before as in the config.merge(state) the setting in the .kitchen.yml
file is overriden by the setting in the Vagrantfile.

Has also added documentation for this configuration

…nt instead of

the default vagrant private key.
Will set the ssh_key in the Vagrantfile if the ssh_key attribute is set in .kitchen.yml
This didn't work before as in the config.merge(state) the setting in the .kitchen.yml
file is overriden by the setting in the Vagrantfile.

Has also added documentation for this configuration
@gildegoma
Copy link
Contributor

👍 More generally, SSH login and key should be overridable, hence #24... (Note, that I added my line in different place of common_block and thus it may need some extra clean up when both are merged. sorry...)

@fnichol
Copy link
Contributor

fnichol commented Jul 22, 2013

Looks good; do you happen to have an Opscode CLA signed?

@fnichol
Copy link
Contributor

fnichol commented Aug 29, 2013

@manul Any update on signing the Opscode CLA. If not I should be able to contribute this under my name and give you a credit. Thanks!

@manul
Copy link
Contributor Author

manul commented Sep 5, 2013

Sorry for the delay, we have been on vacation but the Opscoe CLA is signed now

@manul manul closed this Sep 5, 2013
@manul manul reopened this Sep 5, 2013
@fnichol
Copy link
Contributor

fnichol commented Sep 5, 2013

Awesome, will merge this in, thanks!

@sethvargo
Copy link
Contributor

Merged in ef31e96

@sethvargo sethvargo closed this Nov 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants