Prevent Ryuk from removing itself #53
Conversation
|
Actually, Ryuk shouldn't be labeled with the same label that it targets, that's a bug in Ryuk's consumer. Here is the relevant piece in Testcontainers for Java: |
|
@bsideup Yes, It is a bug in testcontainers-go. In the meantime this PR to ensure that ryuk handles this incorrect consumer behavior as suggested by @HofmeisterAn. |
- Workaround for testcontainers/testcontainers-go#698 - Add generic label to the ryuk image `org.testcontainers.ryuk` which enables the ryuk to detect itself and prevent deletions.
matthewmcnew
force-pushed
the
skip-deleting-ryuk-container
branch
from
cd53ad6
to
6fe2567
Compare
|
Yup, I agree it is in the first place an issue in Ryuk's consumer, but it sounds reasonable to prevent others from running into the same issue. My idea was to start a discussion in |
|
@matthewmcnew thanks for the issue report and your work here. Much appreciated! |
* main: Prevent Ryuk from removing itself (testcontainers#53) Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 (testcontainers#61) chore: add dependabot updates (testcontainers#59) chore: sync governance files (testcontainers#58) chore: bump testcontainers-go to v0.18.0 (testcontainers#57) Bump github.com/containerd/containerd from 1.6.8 to 1.6.18 (testcontainers#55)
org.testcontainers.ryukwhich enables the ryuk to detect itself and prevent deletions.