Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce a new Testcontainers.Xunit package #1165
feat: Introduce a new Testcontainers.Xunit package #1165
Changes from all commits
fd154c0
79e1ffe
b4b60e8
39df223
f675189
7289881
dc66835
181c812
610f7ba
85120de
bb58f4b
8de9b29
f06b8df
d7b0ec5
2c7a09b
e0a1bf8
77eab50
786801b
e8fa351
34d8a49
d9960df
45d2fc8
c47c30d
7aa2067
a2151a7
630a073
313b01e
4f8394f
3eb96b5
0793d06
285df3b
2e79dd7
53b6290
8a286b2
ea693d8
aeb8cd5
250d6a4
5448078
80b1f1d
df9eb0f
b77a426
7717214
ef3b269
64ce5b7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we provide the
configure
overload here? Wouldn't it be sufficient to expect developers to override the member?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially wrote it like that for no particular reason. We can probably get rid of it, if only for consistency with how it's done with
ContainerFixture
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, I take that back, it's pretty convenient actually. For example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably an interesting use case, indeed. We should document it somehow, otherwise no one will know about the overload.