fix reuse not working and improve mix task with watch feature #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarlah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensures that the reuse functionality gets same hash across all versions of the library, so updating the library wont create more containers. Also fixed a problem where reuse never worked. Before it always triggered. Now it never triggers. After this PR it will trigger if the reuse property is set to true in ~/.testcontainers.properties 🙈
Mix task can now run like this:
mix testcontainers.test --watch lib --watch testIf cancelled before tests are completed, the tests will continue to run, because its run as a standalone os command via System.cmd. Rerunning before finished in the background is not guaranteed to work properly because tests will use the same container.
fixes #129