Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RabbitMQ container module #85

Merged
merged 4 commits into from
May 9, 2024
Merged

Add RabbitMQ container module #85

merged 4 commits into from
May 9, 2024

Conversation

zteln
Copy link
Contributor

@zteln zteln commented May 4, 2024

Adds support for a RabbitMQ container.

Copy link
Member

@jarlah jarlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok. It has tests, actual usage with asserts afaik.Can you look at the comments and i can approve after whatever new commits or explanations you come with

lib/container/rabbitmq_container.ex Show resolved Hide resolved
lib/container/rabbitmq_container.ex Show resolved Hide resolved
@zteln
Copy link
Contributor Author

zteln commented May 4, 2024

I added a commit that allows overriding of the listening port on the RabbitMQ node in the Docker container to the port given in RabbitMQContainer.with_port/2 function.

@zteln
Copy link
Contributor Author

zteln commented May 5, 2024

@jarlah the tests seems to have failed for other reasons, could they be triggered again?

@jarlah
Copy link
Member

jarlah commented May 5, 2024

im waiting for the emqx container to get ready .. will hold release before thats finished. For that reason I will let this issue lay here for a tiny bit longer before merging. But looks ok, good work 🚀 Thanks for the contribution!

@jarlah jarlah added the enhancement New feature or request label May 5, 2024
@jarlah jarlah merged commit f6e1bd0 into testcontainers:main May 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants