Skip to content

Commit

Permalink
fix!: remove deprecated EnpointSettingsModifier
Browse files Browse the repository at this point in the history
  • Loading branch information
NathanBaulch committed Jan 12, 2025
1 parent 6dd6836 commit 3f8f581
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion container.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ type ContainerRequest struct {
CapDrop []string // Deprecated: Use HostConfigModifier instead. Drop Linux capabilities
ConfigModifier func(*container.Config) // Modifier for the config before container creation
HostConfigModifier func(*container.HostConfig) // Modifier for the host config before container creation
EnpointSettingsModifier func(map[string]*network.EndpointSettings) // Deprecated: Use EndpointSettingsModifier instead
EndpointSettingsModifier func(map[string]*network.EndpointSettings) // Modifier for the network settings before container creation
LifecycleHooks []ContainerLifecycleHooks // define hooks to be executed during container lifecycle
LogConsumerCfg *LogConsumerConfig // define the configuration for the log producer and its log consumers to follow the logs
Expand Down
2 changes: 0 additions & 2 deletions lifecycle.go
Original file line number Diff line number Diff line change
Expand Up @@ -557,8 +557,6 @@ func (p *DockerProvider) preCreateContainerHook(ctx context.Context, req Contain

if req.EndpointSettingsModifier != nil {
req.EndpointSettingsModifier(endpointSettings)
} else if req.EnpointSettingsModifier != nil {
req.EnpointSettingsModifier(endpointSettings)
}

networkingConfig.EndpointsConfig = endpointSettings
Expand Down
1 change: 0 additions & 1 deletion options.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ func WithConfigModifier(modifier func(config *container.Config)) CustomizeReques
// WithEndpointSettingsModifier allows to override the default endpoint settings
func WithEndpointSettingsModifier(modifier func(settings map[string]*network.EndpointSettings)) CustomizeRequestOption {
return func(req *GenericContainerRequest) error {
req.EnpointSettingsModifier = modifier
req.EndpointSettingsModifier = modifier

return nil
Expand Down
2 changes: 0 additions & 2 deletions reaper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ func (m *mockReaperProvider) RunContainer(ctx context.Context, req ContainerRequ

if req.EndpointSettingsModifier != nil {
req.EndpointSettingsModifier(m.endpointSettings)
} else if req.EnpointSettingsModifier != nil {
req.EnpointSettingsModifier(m.endpointSettings)
}

// we're only interested in the request, so instead of mocking the Docker client
Expand Down

0 comments on commit 3f8f581

Please sign in to comment.