Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure IPAM for networks #299

Closed
aivinog1 opened this issue Mar 22, 2021 · 2 comments · Fixed by #394
Closed

Allow to configure IPAM for networks #299

aivinog1 opened this issue Mar 22, 2021 · 2 comments · Fixed by #394

Comments

@aivinog1
Copy link
Contributor

Right now I can't configure IPAM parameters for the network that I create, but I see these parameters in this struct (the Go docker client):

// NetworkCreate is the expected body of the "create network" http request message
type NetworkCreate struct {
	// Check for networks with duplicate names.
	// Network is primarily keyed based on a random ID and not on the name.
	// Network name is strictly a user-friendly alias to the network
	// which is uniquely identified using ID.
	// And there is no guaranteed way to check for duplicates.
	// Option CheckDuplicate is there to provide a best effort checking of any networks
	// which has the same name but it is not guaranteed to catch all name collisions.
	CheckDuplicate bool
	Driver         string
	Scope          string
	EnableIPv6     bool
	IPAM           *network.IPAM
	Internal       bool
	Attachable     bool
	Ingress        bool
	ConfigOnly     bool
	ConfigFrom     *network.ConfigReference
	Options        map[string]string
	Labels         map[string]string
}

It would be nice if the testcontainers allows configuring this parameter.

@mdelapenya
Copy link
Member

I'd say it would be fairly easy to add it to our network request struct.

Would you mind submitting a PR with that? Including tests would be more than super!

@aivinog1
Copy link
Contributor Author

aivinog1 commented Oct 2, 2021

Hey @mdelapenya! Sure, I'm happy to create PR with it 🙂. But for now, I'm pretty busy with my current tasks, so I can't promise any due date or something 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants