-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modulegen: create internal/module #1505
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes regarding package name.
BTW I'm liking how you're setting up the layout for the module generation tool! Congrats!
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* main: (26 commits) modulegen: create internal/make (testcontainers#1537) chore: fix workflow (testcontainers#1538) chore(deps): bump the all group in /examples/cockroachdb with 1 update (testcontainers#1522) chore(deps): bump the all group in /examples/bigtable with 1 update (testcontainers#1534) chore(deps): bump the all group in /modules/localstack with 4 updates (testcontainers#1535) chore(deps): bump the all group in /modules/k3s with 2 updates (testcontainers#1526) chore(deps): bump the all group in /examples/spanner with 2 updates (testcontainers#1532) chore(deps): bump the all group in /examples/firestore with 1 update (testcontainers#1523) chore(deps): bump the all group in /modules/redis with 1 update (testcontainers#1524) chore(deps): bump the all group in /modules/clickhouse with 1 update (testcontainers#1525) chore(deps): bump the all group in /examples/toxiproxy with 2 updates (testcontainers#1528) chore(deps): bump the all group in /examples/pubsub with 1 update (testcontainers#1531) chore(deps): bump the all group in /examples/datastore with 2 updates (testcontainers#1530) chore(deps): bump the all group in /modules/redpanda with 1 update (testcontainers#1527) chore: properly render mkdocs.yml (testcontainers#1521) modulegen: create internal/workflow (testcontainers#1520) modulegen: create internal/module (testcontainers#1505) modulegen: create internal/mkdocs (testcontainers#1504) fix: do not remove the file schema in docker.host property (testcontainers#1517) fix: reset config in tests (testcontainers#1516) ...
Refactor exec (go vet and go mod tidy) code in modulegen