-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(sonarcloud): upload artifact #1614
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, although before approving I'd like to first discuss https://github.com/testcontainers/testcontainers-go/pull/1614/files#r1324001839
Right after that, I think this is ready to go.
Again, probably this is not adding features to the end-users, but adding lots of value to the maintainability of the project 🚀, which makes a lot for me. Thanks!!!
By the way, you’ll need to update the pre release script so the version is also updated in sonar properties |
Will do it in a follow-up, thanks! |
@mmorel-35 here you have it: #1615 |
* main: up (testcontainers#1617) chore: update sonarcloud properties when releasing the project (testcontainers#1615) ci(sonarcloud): upload artifact (testcontainers#1614)
What does this PR do?
Uploads unit-tests.xml and coverage.out in the sonarcloud artifact during the test phase. After the test-examples job the sonarcloud scan is executed with the artifacts uploaded.
Why is it important?
This helps providing a correct code coverage on sonarcloud