Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for k3s node to sync #1685

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

pablochacin
Copy link
Contributor

What does this PR do?

Changes the waiting condition for k3s container to wait for the k3s node to finish the synchronization.

Why is it important?

This change ensures the API server is able to respond to requests preventing issues such as described in this thread.

Related issues

How to test this PR

Follow-ups

@pablochacin pablochacin requested a review from a team as a code owner September 25, 2023 10:26
@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit bfed454
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6511b027acad040007e93353
😎 Deploy Preview https://deploy-preview-1685--testcontainers-go.netlify.app/modules/k3s
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pablochacin pablochacin marked this pull request as draft September 25, 2023 10:29
mdelapenya
mdelapenya previously approved these changes Sep 25, 2023
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya self-assigned this Sep 25, 2023
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Sep 25, 2023
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin
Copy link
Contributor Author

Hi @mdelapenya I just updated the PR. I'm sorry I didn't see your comment.
I wanted to add a test that the API server was actually ready so I renamed the test files to make clear which are actual tests and which are examples.

mdelapenya
mdelapenya previously approved these changes Sep 25, 2023
docs/modules/k3s.md Outdated Show resolved Hide resolved
@mdelapenya mdelapenya merged commit fd8912f into testcontainers:main Sep 25, 2023
15 checks passed
mdelapenya added a commit that referenced this pull request Sep 26, 2023
…ers/image-spec-1.1.0-rc5

* main:
  chore(deps): bump github.com/shirou/gopsutil/v3 from 3.23.7 to 3.23.8 (#1651)
  Wait for k3s node to sync (#1685)
  chore(deps): bump github.com/IBM/sarama in /modules/kafka (#1637)
  chore(deps): bump github.com/ClickHouse/clickhouse-go/v2 (#1625)
  chore(deps): bump github.com/elastic/go-elasticsearch/v8 (#1641)
  chore(deps): bump github.com/tidwall/gjson from 1.16.0 to 1.17.0 in /modules/couchbase and /modules/vault (#1684)
mdelapenya added a commit that referenced this pull request Sep 26, 2023
….com/docker/compose/v2-2.22.0

* main:
  chore(deps): bump golang.org/x/text to v0.15.0 (#1687)
  chore(deps): bump github.com/shirou/gopsutil/v3 from 3.23.7 to 3.23.8 (#1651)
  Wait for k3s node to sync (#1685)
  chore(deps): bump github.com/IBM/sarama in /modules/kafka (#1637)
  chore(deps): bump github.com/ClickHouse/clickhouse-go/v2 (#1625)
  chore(deps): bump github.com/elastic/go-elasticsearch/v8 (#1641)
  chore(deps): bump github.com/tidwall/gjson from 1.16.0 to 1.17.0 in /modules/couchbase and /modules/vault (#1684)
  chore(deps): bump mkdocs from 1.5.2 to 1.5.3 (#1662)
  chore(deps): bump github.com/nats-io/nats.go in /modules/nats (#1657)
  chore(deps): bump k8s.io/apimachinery from 0.28.1 to 0.28.2 and k8s.io/client-go from 0.28.1 to 0.28.2 in /modules/k3s (#1683)
  chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.18.39 to 1.18.42 and github.com/aws/aws-sdk-go from 1.45.3 to 1.45.15 and github.com/aws/aws-sdk-go-v2/service/s3 from 1.38.5 to 1.39.0 in /modules/localstack (#1680)
  chore(deps): bump github.com/twmb/franz-go/pkg/kadm from 1.9.0 to 1.9.1 and github.com/twmb/franz-go from 1.14.4 to 1.15.0 in /modules/redpanda (#1682)
  chore(deps): bump cloud.google.com/go/datastore from 1.13.0 to 1.14.0 and google.golang.org/grpc from 1.58.1 to 1.58.2 and cloud.google.com/go/spanner from 1.47.0 to 1.49.0 in /modules/gcloud (#1681)
  feat: add GCloud module (#1670)
  make ryuk timeouts configurable via properties file (#1668)
  chore(deps): bump mkdocs-material from 8.2.7 to 9.3.2 (#1649)
  chore(deps): bump google.golang.org/grpc from 1.57.0 to 1.58.1 and google.golang.org/api from 0.138.0 to 0.142.0 in /examples (#1667)
  feat: support for loading images in the K3s module (#1622)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Improve wait condition for k3s
2 participants