-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WithEnv customize request option #2260
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a11d106
to
a7efb55
Compare
e3b0ffa
to
56884a9
Compare
The one failing test here looks like a temporary infrastructure issue, not related to the PR, recommend forcing it to rerun. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Added a few comments, but in general LGTM.
Also, could you look up the existing modules and check if we can apply this option to them? 🙏
56884a9
to
2d43a16
Compare
2d43a16
to
3b5fb35
Compare
Should be good now @mdelapenya |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this contribution, I appreciate very much your work here! 🙇
I'll merge this one once the comment in the docs is addressed.
3b5fb35
to
39fc242
Compare
Add WithEnv which set additional environment variables on a request so that callers can customise a request. This can be used to easily add environment variables to a container created using one of the standard module e.g. postgres.
39fc242
to
1198de4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What does this PR do?
Add WithEnv which set additional environment variables on a request so that callers can customise a request.
Why is it important?
This can be used to easily add environment variables to a container created using one of the standard module e.g. postgres.
How to test this PR
go test -run=^TestWithEnv$