Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): pass docker install type to the nightly build payload #2612

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

mdelapenya
Copy link
Collaborator

  • chore: continue on error for the nightly build
  • chore: pass docker install type to the payload

What does this PR do?

This PR enrichs the JSON payload we submit to Slack when the test-docker-latest build fails, passing if the docker was installed as rootful or rootless.

Why is it important?

Have a quicker preview of the root cause of the error in the Slack message

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner June 28, 2024 08:04
@mdelapenya mdelapenya added chore Changes that do not impact the existing functionality github_actions Pull requests that update GitHub Actions code labels Jun 28, 2024
@mdelapenya mdelapenya self-assigned this Jun 28, 2024
Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit df8f174
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/667e6e7753902b0008b3e92f
😎 Deploy Preview https://deploy-preview-2612--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya merged commit 401ab9b into testcontainers:main Jun 28, 2024
106 of 108 checks passed
@mdelapenya mdelapenya deleted the nightly-refinements branch June 28, 2024 08:56
mdelapenya added a commit that referenced this pull request Jun 28, 2024
* main:
  chore(ci): pass docker install type to the nightly build payload (#2612)
  chore: run rootless mode in nighlty builds (#2611)
  chore(deps): bump github.com/hashicorp/go-retryablehttp (#2605)
  chore: improve log handling when container is stopping (#2601)
mdelapenya added a commit to thaJeztah/testcontainers-go that referenced this pull request Jun 28, 2024
* main:
  chore: test cleanups (testcontainers#2608)
  chore(ci): pass docker install type to the nightly build payload (testcontainers#2612)
  chore: run rootless mode in nighlty builds (testcontainers#2611)
  chore(deps): bump github.com/hashicorp/go-retryablehttp (testcontainers#2605)
  chore: improve log handling when container is stopping (testcontainers#2601)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jul 2, 2024
* main:
  chore(deps): bump github.com/docker/docker from v26.1.4 to v27.0.2 (testcontainers#2593)
  fix: Rename TC_HOST environment variable to TESTCONTAINERS_HOST_OVERRIDE (testcontainers#2536)
  chore: test cleanups (testcontainers#2608)
  chore(ci): pass docker install type to the nightly build payload (testcontainers#2612)
  chore: run rootless mode in nighlty builds (testcontainers#2611)
  chore(deps): bump github.com/hashicorp/go-retryablehttp (testcontainers#2605)
  chore: improve log handling when container is stopping (testcontainers#2601)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant