Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres): duplicate snapshot name #2840

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Oct 18, 2024

Fix postgres snapshot name reuse by removing its template flag before trying to delete it.

Fixes #2822

@stevenh stevenh requested a review from a team as a code owner October 18, 2024 22:54
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 5f7aa3d
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/671627d8b970150009632057
😎 Deploy Preview https://deploy-preview-2840--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya self-assigned this Oct 19, 2024
@mdelapenya mdelapenya added the bug An issue with the library label Oct 19, 2024
mdelapenya
mdelapenya previously approved these changes Oct 19, 2024
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just one nit

modules/postgres/postgres.go Show resolved Hide resolved
Fix postgres snapshot name reuse by removing its template flag before
trying to delete it.

Fixes #2822
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update!

@mdelapenya mdelapenya merged commit 235ab07 into main Oct 21, 2024
120 checks passed
@mdelapenya mdelapenya deleted the fix/postgres-snapshot branch October 21, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot call Snapshot() twice with the same snapshot_name on a postgres testcontainer
2 participants