Skip to content

Commit

Permalink
Use testCompileOnly instead of testCompileClasspath (#5849)
Browse files Browse the repository at this point in the history
`testCompileClasspath` is deprecated. Also, removing `org.jetbrains:annotations`
from `selenium` module.
  • Loading branch information
eddumelendez authored Sep 19, 2022
1 parent 22aa85d commit 459d2f6
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ dependencies {
api 'junit:junit:4.13.2'
api 'org.slf4j:slf4j-api:2.0.0'
compileOnly 'org.jetbrains:annotations:23.0.0'
testCompileClasspath 'org.jetbrains:annotations:23.0.0'
testCompileOnly 'org.jetbrains:annotations:23.0.0'
api 'org.apache.commons:commons-compress:1.21'
api ('org.rnorth.duct-tape:duct-tape:1.0.8') {
exclude(group: 'org.jetbrains', module: 'annotations')
Expand Down
1 change: 0 additions & 1 deletion modules/selenium/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ dependencies {
testImplementation 'org.assertj:assertj-core:3.23.1'

compileOnly 'org.jetbrains:annotations:23.0.0'
testCompileClasspath 'org.jetbrains:annotations:23.0.0'
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.testcontainers.junit;

import org.jetbrains.annotations.NotNull;
import org.junit.ClassRule;
import org.openqa.selenium.By;
import org.openqa.selenium.WebElement;
Expand Down Expand Up @@ -51,7 +50,6 @@ protected void assertBrowserNameIs(BrowserWebDriverContainer<?> rule, String exp
assertThat(actual).as(String.format("actual browser name is %s", actual)).isEqualTo(expectedName);
}

@NotNull
private static RemoteWebDriver setupDriverFromRule(BrowserWebDriverContainer<?> rule) {
RemoteWebDriver driver = rule.getWebDriver();
driver.manage().timeouts().implicitlyWait(30, TimeUnit.SECONDS);
Expand Down
2 changes: 1 addition & 1 deletion modules/spock/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ dependencies {
testRuntimeOnly 'org.postgresql:postgresql:42.5.0'
testRuntimeOnly 'mysql:mysql-connector-java:8.0.30'

testCompileClasspath 'org.jetbrains:annotations:23.0.0'
testCompileOnly 'org.jetbrains:annotations:23.0.0'
}

sourceJar {
Expand Down

0 comments on commit 459d2f6

Please sign in to comment.