Skip to content

Commit

Permalink
Document in CHANGELOG.md, add deprecation comments
Browse files Browse the repository at this point in the history
  • Loading branch information
bsideup committed Jan 27, 2018
1 parent 2159f02 commit 72f99af
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ All notable changes to this project will be documented in this file.

### Changed
- Added Kafka module ([\#546](https://github.com/testcontainers/testcontainers-java/pull/546))
- Environment variables are now stored as Map instead of List ([\#550](https://github.com/testcontainers/testcontainers-java/pull/550))
- Added `withEnv(String name, Function<Optional<String>, String> mapper)` with optional previous value ([\#550](https://github.com/testcontainers/testcontainers-java/pull/550))
- Added `withFileSystemBind` overloaded method with `READ_WRITE` file mode by default ([\#550](https://github.com/testcontainers/testcontainers-java/pull/550))

## [1.5.1] - 2017-12-19

Expand Down
12 changes: 12 additions & 0 deletions core/src/main/java/org/testcontainers/containers/Container.java
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,10 @@ default Integer getFirstMappedPort() {
*/
SELF withLogConsumer(Consumer<OutputFrame> consumer);

/**
*
* @deprecated please use {@code org.testcontainers.DockerClientFactory.instance().client().infoCmd().exec()}
*/
@Deprecated
Info fetchDockerDaemonInfo() throws IOException;

Expand Down Expand Up @@ -485,13 +489,21 @@ ExecResult execInContainer(Charset outputCharset, String... command)

DockerClient getDockerClient();

/**
*
* @deprecated please use {@code org.testcontainers.DockerClientFactory.instance().client().infoCmd().exec()}
*/
@Deprecated
Info getDockerDaemonInfo();

String getContainerId();

String getContainerName();

/**
*
* @deprecated please use {@code org.testcontainers.DockerClientFactory.instance().client().inspectContainerCmd(container.getContainerId()).exec()}
*/
@Deprecated
InspectContainerResponse getContainerInfo();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -912,6 +912,9 @@ public SELF withLogConsumer(Consumer<OutputFrame> consumer) {
return self();
}

/**
* {@inheritDoc}
*/
@Override
public synchronized Info fetchDockerDaemonInfo() throws IOException {

Expand Down

0 comments on commit 72f99af

Please sign in to comment.